Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account address is different while use same Mnemonic by starknet.dart BraavosAccountDerivation and braavos wallet #393

Open
gtmickey opened this issue Aug 1, 2024 · 1 comment

Comments

@gtmickey
Copy link

gtmickey commented Aug 1, 2024

Describe the bug
Account address is different while use same Mnemonic by starknet.dart and braavos wallet

To Reproduce
Steps to reproduce the behavior:

  1. import Mnemonic to braavos wallet: smoke clock senior verb tube steak wealth cram absorb robust long mutual
  2. wallet show account address: 0x002b945db72c8bb7361ca7457fc3dd3b35831d359c99ee03fddc24f847326d6d
  3. create account by same Mnemonic with Account.fromMnemonic,
 final account = Account.fromMnemonic(
      mnemonic: mnemonic,
      provider: provider, // mainnet
      chainId: chainId, // mainnet chainId
      index: index, // 0
      accountDerivation: accountDerivation, // default to  BraavosAccountDerivation
    );
  1. address is 0x17524b0b247a01969d21d626175d449fc0fb7d3b5fc467a9d22c16f58abc4fd

Expected behavior
same Mnemonic should have same address with Braavos wallet and BraavosAccountDerivation on starknet.dart

@gtmickey gtmickey changed the title Account address is different while use same Mnemonic by starknet.dart and braavos wallet Account address is different while use same Mnemonic by starknet.dart BraavosAccountDerivation and braavos wallet Aug 1, 2024
@devnet0x
Copy link
Contributor

Hi, this is caused because braavos change their class_hash a few months ago. Also, their calldata only needs public key. I sent PR #407 to fix this issue. Please check...thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants