From 06863aeca181b4dbb593ddb3b530e6aaf7d7ef70 Mon Sep 17 00:00:00 2001
From: Jordan Borean <jborean93@gmail.com>
Date: Fri, 3 Jan 2025 22:01:11 +1000
Subject: [PATCH] Add SMB2 attribute tag and fix SMB2 query results (#1835)

Adds the FILE_ATTRIBUTE_TAG_INFORMATION structure that can be requested
in an SMB2 query info request. Returns the SMB2_FILE_BASIC_INFO result
for SMB2 queries and return the SMB2 not the SMB1 structure for
SMB2_FILE_STANDARD_INFO.
---
 impacket/smb3structs.py |  6 ++++++
 impacket/smbserver.py   | 39 +++++++++++++++++++++++++++------------
 2 files changed, 33 insertions(+), 12 deletions(-)

diff --git a/impacket/smb3structs.py b/impacket/smb3structs.py
index efd1ec740..556e3e6f0 100644
--- a/impacket/smb3structs.py
+++ b/impacket/smb3structs.py
@@ -1496,6 +1496,12 @@ class FILE_ALL_INFORMATION(Structure):
         ('NameInformation',':',FILE_NAME_INFORMATION),
     )
 
+class FILE_ATTRIBUTE_TAG_INFORMATION(Structure):
+    structure = (
+        ('FileAttributes','<L'),
+        ('ReparseTag','<L=0'),
+    )
+
 # SMB2_SET_INFO
 class SMB2SetInfo(Structure):
     SIZE = 32
diff --git a/impacket/smbserver.py b/impacket/smbserver.py
index 70955abc1..5cf877ffa 100644
--- a/impacket/smbserver.py
+++ b/impacket/smbserver.py
@@ -532,20 +532,38 @@ def queryPathInformation(path, filename, level):
 
         if os.path.exists(pathName):
             (mode, ino, dev, nlink, uid, gid, size, atime, mtime, ctime) = os.stat(pathName)
+            if os.path.isdir(pathName):
+                fileAttributes = smb.ATTR_DIRECTORY
+            else:
+                fileAttributes = smb.ATTR_NORMAL | smb.ATTR_ARCHIVE
+
             if level == smb.SMB_QUERY_FILE_BASIC_INFO:
                 infoRecord = smb.SMBQueryFileBasicInfo()
                 infoRecord['CreationTime'] = getFileTime(ctime)
                 infoRecord['LastAccessTime'] = getFileTime(atime)
                 infoRecord['LastWriteTime'] = getFileTime(mtime)
                 infoRecord['LastChangeTime'] = getFileTime(mtime)
+                infoRecord['ExtFileAttributes'] = fileAttributes
+            elif level == smb2.SMB2_FILE_BASIC_INFO:
+                infoRecord = smb2.FILE_BASIC_INFORMATION()
+                infoRecord['CreationTime'] = getFileTime(ctime)
+                infoRecord['LastAccessTime'] = getFileTime(atime)
+                infoRecord['LastWriteTime'] = getFileTime(mtime)
+                infoRecord['ChangeTime'] = getFileTime(mtime)
+                infoRecord['FileAttributes'] = fileAttributes
+            elif level == smb.SMB_QUERY_FILE_STANDARD_INFO:
+                infoRecord = smb.SMBQueryFileStandardInfo()
+                infoRecord['AllocationSize'] = size
+                infoRecord['EndOfFile'] = size
                 if os.path.isdir(pathName):
-                    infoRecord['ExtFileAttributes'] = smb.ATTR_DIRECTORY
+                    infoRecord['Directory'] = 1
                 else:
-                    infoRecord['ExtFileAttributes'] = smb.ATTR_NORMAL | smb.ATTR_ARCHIVE
-            elif level == smb.SMB_QUERY_FILE_STANDARD_INFO or level == smb2.SMB2_FILE_STANDARD_INFO:
-                infoRecord = smb.SMBQueryFileStandardInfo()
+                    infoRecord['Directory'] = 0
+            elif level == smb2.SMB2_FILE_STANDARD_INFO:
+                infoRecord = smb2.FILE_STANDARD_INFORMATION()
                 infoRecord['AllocationSize'] = size
                 infoRecord['EndOfFile'] = size
+                infoRecord['NumberOfLinks'] = 0
                 if os.path.isdir(pathName):
                     infoRecord['Directory'] = 1
                 else:
@@ -556,10 +574,7 @@ def queryPathInformation(path, filename, level):
                 infoRecord['LastAccessTime'] = getFileTime(atime)
                 infoRecord['LastWriteTime'] = getFileTime(mtime)
                 infoRecord['LastChangeTime'] = getFileTime(mtime)
-                if os.path.isdir(pathName):
-                    infoRecord['ExtFileAttributes'] = smb.ATTR_DIRECTORY
-                else:
-                    infoRecord['ExtFileAttributes'] = smb.ATTR_NORMAL | smb.ATTR_ARCHIVE
+                infoRecord['ExtFileAttributes'] = fileAttributes
                 infoRecord['AllocationSize'] = size
                 infoRecord['EndOfFile'] = size
                 if os.path.isdir(pathName):
@@ -609,14 +624,14 @@ def queryPathInformation(path, filename, level):
                 infoRecord['ChangeTime'] = getFileTime(mtime)
                 infoRecord['AllocationSize'] = size
                 infoRecord['EndOfFile'] = size
-                if os.path.isdir(pathName):
-                    infoRecord['FileAttributes'] = smb.ATTR_DIRECTORY
-                else:
-                    infoRecord['FileAttributes'] = smb.ATTR_NORMAL | smb.ATTR_ARCHIVE
+                infoRecord['FileAttributes'] = fileAttributes
             elif level == smb.SMB_QUERY_FILE_EA_INFO or level == smb2.SMB2_FILE_EA_INFO:
                 infoRecord = smb.SMBQueryFileEaInfo()
             elif level == smb.SMB_QUERY_FILE_STREAM_INFO or level == smb2.SMB2_FILE_STREAM_INFO:
                 infoRecord = smb.SMBFileStreamInformation()
+            elif level == smb2.SMB2_ATTRIBUTE_TAG_INFO:
+                infoRecord = smb2.FILE_ATTRIBUTE_TAG_INFORMATION()
+                infoRecord['FileAttributes'] = fileAttributes
             else:
                 LOG.error('Unknown level for query path info! 0x%x' % level)
                 # UNSUPPORTED