Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(releases): make latest an alias of nightly #9579

Closed
zerosnacks opened this issue Dec 19, 2024 · 2 comments
Closed

chore(releases): make latest an alias of nightly #9579

zerosnacks opened this issue Dec 19, 2024 · 2 comments
Assignees
@grandizzy
Labels
A-releases Area: releases/packaging T-chore Type: chore
Milestone
v1.0.0

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Dec 19, 2024 •
edited
Loading

Component

Other (please describe)

Describe the feature you would like

latest is a common alias for nightly, it makes sense to add it

This should also be implemented for the Docker image

Closes: foundry-rs/foundry-toolchain#57

Additional context

No response
@zerosnacks zerosnacks added A-releases Area: releases/packaging T-chore Type: chore labels Dec 19, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Dec 19, 2024
@zerosnacks zerosnacks mentioned this issue Dec 19, 2024
Closed
@l1nxy l1nxy mentioned this issue Dec 20, 2024
Closed
@grandizzy grandizzy self-assigned this Jan 7, 2025
@grandizzy grandizzy added this to the v1.0.0 milestone Jan 7, 2025
@grandizzy
Copy link
Collaborator

@zerosnacks PR #9586 makes foundryup -i latest to install nightly which could make sense, also tagging nightly docker images as latest is OK, however I am not sure we should mark nightly releases as stable but stick with stable, as shown below

Image

wdyt? thank you

@zerosnacks
Copy link
Member Author

zerosnacks commented Jan 15, 2025 •
edited
Loading

I see, if we use "latest" tag to refer to the latest stable release rather than the latest nightly already it makes sense not to conflate latest with nightly now or partially implement it

Looking at it again I think we can close the ticket as "not planned" and just stick to "stable" and "nightly" definitions we already use and people are familiar with and they have explicit definitions

@zerosnacks zerosnacks closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Jan 15, 2025
@grandizzy grandizzy moved this from Done to Completed in Foundry Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grandizzy grandizzy

Labels
A-releases Area: releases/packaging T-chore Type: chore
Projects
Foundry
Status: Completed
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

chore(releases): make latest an alias of nightly l1nxy/foundry
2 participants
@grandizzy @zerosnacks