Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheatcode mocking get_block_hash_syscall #684

Open
MaksymilianDemitraszek opened this issue Sep 18, 2023 · 7 comments · May be fixed by #2648
Open

Cheatcode mocking get_block_hash_syscall #684

MaksymilianDemitraszek opened this issue Sep 18, 2023 · 7 comments · May be fixed by #2648
Assignees
@PedroRosalba
Labels
feature New feature request/description good first issue Good for newcomers OnlyDust Assigned snforge

Comments

@MaksymilianDemitraszek
Copy link
Member 

// Gets the block hash of the block with the given number.
extern fn get_block_hash_syscall(
    block_number: u64
) -> SyscallResult<felt252> implicits(GasBuiltin, System) nopanic;

not urgent, not requested by anybody
@MaksymilianDemitraszek MaksymilianDemitraszek added snforge feature New feature request/description labels Sep 18, 2023
@github-actions github-actions bot added the new label Sep 18, 2023
@Arcticae Arcticae removed the new label Sep 19, 2023
@Arcticae Arcticae mentioned this issue Oct 3, 2023
Closed
@Arcticae Arcticae added the good first issue Good for newcomers label Oct 3, 2023
@Arcticae Arcticae moved this from Triage to TODO in Starknet foundry Oct 16, 2023
@duralsh
Copy link
Contributor

duralsh commented Nov 8, 2023

I can potentially work on this as my next task. Where can i get more information about this issue ?

@Arcticae
Copy link
Contributor

Arcticae commented Nov 8, 2023

@partychad we need to come up with a cheatcode name which mocks the get_block_hash syscall, and implement it in a similar way that others are implemented. I don't think there's much information available apart from that.

get_block_hash works kind of like regular contract call from what i understand, if that helps

@duralsh
Copy link
Contributor

duralsh commented Nov 9, 2023

I want to start working on this issue once my open PRs are merged, if it is okay :)

@Arcticae
Copy link
Contributor

@partychad you are free to assign yourself if you still want it

@Arcticae Arcticae moved this from TODO to Backlog in Starknet foundry Nov 29, 2023
@Arcticae Arcticae moved this from Backlog to Triage in Starknet foundry Mar 5, 2024
@RuneRogue
Copy link

@Arcticae Can you tell me more about this issue? Like where I have to add code or make changes ?

@PedroRosalba
Copy link

I’m interested in this one.

@PedroRosalba
Copy link

Have just done a PR based in what I have understood of the issue. Got a bit confused because the issue does not have a detailed explanation. Let me know any feedbacks so that I can continue working on this.

@kkawula kkawula linked a pull request Nov 7, 2024 that will close this issue
Open
5 tasks
@cptartur cptartur mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PedroRosalba PedroRosalba

Labels
feature New feature request/description good first issue Good for newcomers OnlyDust Assigned snforge
Projects
Starknet foundry
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cheatcode for getting hash of the block PedroRosalba/starknet-foundry
6 participants
@MaksymilianDemitraszek @Arcticae @cptartur @PedroRosalba @duralsh @RuneRogue