Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to artifacts.rs module #2625

Closed
cptartur opened this issue Oct 30, 2024 · 2 comments · Fixed by #2680
Closed

Add unit tests to artifacts.rs module #2625

cptartur opened this issue Oct 30, 2024 · 2 comments · Fixed by #2680
Assignees
@Abeeujah
Labels
help wanted maintenance OnlyDust Assigned snforge

Comments

@cptartur
Copy link
Member

cptartur commented Oct 30, 2024 •
edited
Loading

Unit tests functions linked in code with this issue.
@cptartur cptartur converted this from a draft issue Oct 30, 2024
@github-actions github-actions bot added the new label Oct 30, 2024
@Abeeujah
Copy link
Contributor

Hi, I'd love to work on this, is there more details or context I'd need before I jump on this?

@liucanzhu
Copy link

Hi. I'd love to try it！！！！

@Abeeujah Abeeujah mentioned this issue Nov 16, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 22, 2025
@Abeeujah
test: Add unit tests to artifacts.rs module (#2680)
ebde2bb 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #2625 

## Introduced changes
Tests directory in `crates/scarb-api/tests/data/basic_package` for
integration tests starknet artifacts.


<!-- A brief description of the changes -->
Integration tests artifacts only get built when there's a tests
directory in a cairo package
-

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Starknet foundry Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abeeujah Abeeujah

Labels
help wanted maintenance OnlyDust Assigned snforge
Projects
Starknet foundry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add unit tests to artifacts.rs module Abeeujah/starknet-foundry
3 participants
@cptartur @liucanzhu @Abeeujah