Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMARC align check may broken if TLD is used to send mails #736

Closed
mschneider82 opened this issue Dec 9, 2024 · 1 comment
Closed

DMARC align check may broken if TLD is used to send mails #736

mschneider82 opened this issue Dec 9, 2024 · 1 comment
Labels
bug Something isn't working.

Comments

@mschneider82
Copy link
Contributor

I had some dkim alignment issues with mail domains listed as a TLD in https://publicsuffix.org/list/public_suffix_list.dat
For example: if gitlab.io is used to send DKIM DMARC mails, with a policy adkim=r restricted policy, the isAligned() function will return an error because it cannot find a domain:

https://github.com/foxcpp/maddy/blob/master/internal/dmarc/evaluate.go#L212

It can be fixed by adding in line 209:

	tld, _ := publicsuffix.PublicSuffix(fromDomain)
	if strings.EqualFold(fromDomain, tld) {
		return strings.EqualFold(fromDomain, authDomain)
	}

If you want, i can make a PR for that, or if you have another solution feel free! thanks!
I know the DKIM RFC doesnt handle this case well and require to use a Organisational Domain but there are quite a few big goverment domains used for mailing in that list.

@mschneider82 mschneider82 added the bug Something isn't working. label Dec 9, 2024
mschneider82 added a commit to mschneider82/maddy that referenced this issue Dec 9, 2024
foxcpp added a commit that referenced this issue Jan 24, 2025
#736: dmarc evalute added check if fromDomain is a TLD
@mschneider82
Copy link
Contributor Author

fixed in #737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant