Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctype cache is never used #41

Open
ankush opened this issue Jul 15, 2023 · 1 comment
Open

doctype cache is never used #41

ankush opened this issue Jul 15, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ankush
Copy link
Member

ankush commented Jul 15, 2023

https://github.com/frappe/frappe/blob/ba311a3ec83807f8a07f55e4beac6a09a7108b77/frappe/desk/form/load.py#L73-L74

comparing DateTime with string will always be false.

Also, this whole caching implementation is weird. If request is made and all the cost is paid then what's the point of not sending data back? Few KBs of network i/o saved at max.

NOTE: don't just fix it. Since this never really worked, the implementation is also flaky. Sometimes dependent doc meta is not cached which results in broken forms.

IMO lets just remove this entirely and redo cache implementation.

@ankush ankush added the bug Something isn't working label Jul 15, 2023
@sagarvora
Copy link

Yes, let's redo JS cache implementation 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants