Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with marshmallow-enum dead end #9

Open
obscurerichard opened this issue Jan 1, 2025 · 0 comments
Open

Deal with marshmallow-enum dead end #9

obscurerichard opened this issue Jan 1, 2025 · 0 comments
Labels

Comments

@obscurerichard
Copy link
Member

We rely on Marshmallow for object serialization.

However, not all parts of this ecosystem are well-maintained.

This is a nasty little one because we rely on this for mapping incoming Strava API JSON to our ORM objects. The marshmallow-enum feature relies on a bug fix Lyft made to this now-archived library. See justanr/marshmallow_enum#34 and https://github.com/lyft/marshmallow_enum/tree/support-for-marshamallow-3 . We were able to get to Marshmallow 3 but this dependency is kind of difficult.

Consider switching to another library or reworking our code so we don't depend on the enum part anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Icebox
Development

No branches or pull requests

1 participant