Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to deal with versioning after migrating off TC #5

Open
BeeWarloc opened this issue May 14, 2018 · 1 comment
Open

Figure out how to deal with versioning after migrating off TC #5

BeeWarloc opened this issue May 14, 2018 · 1 comment

Comments

@BeeWarloc
Copy link
Contributor

BeeWarloc commented May 14, 2018

Now that we're migrating off TC we should figure out a new way to handle versioning of builds. Ideally the same method should also be usable for uno and fuselibs repos.

Things to consider:

  • Should we take our version from a tag, or use from VERSION.txt as we do today?
  • Should our snapshots and pre-releases be based on the previous or next version number?
  • Should a local build of release commit X.Y.Z have version number X.Y.Z or X.Y.Z-somesuffix?

If we get our versions from tags I know of at least two alternatives we could use:

@BeeWarloc
Copy link
Contributor Author

Currently the way we handle versions in scripts when built locally is a bit of mess.

In pack.sh version is set to the content of VERSION.txt with -local suffix added.

In the macOS installer build.sh the version string is set to a combination of timestamp and commit hash.

Also we don't update the AssemblyInfo versions. I got a WIP branch for that here, but not yet sure about the approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant