Intermittent error "Cyclic states exhausted"

[RobertWilbrandt]

The driver sometimes crashes with a std::runtime_error stating "Cyclic states exhausted". This is not frequent, an example in CI is this run.

I don't yet have a way to reproduce this reliably and don't know what could cause this. The problem has however already occurred with the first driver version.

The RsiFactory class is used to prevent memory allocations during runtime. As the number of RsiState and RsiCommand objects is bounded, a fixed number is allocated at startup and kept in a ring buffer. Whenever the parser or the hardware interface requires a new instance, the next one is taken from the buffer. In order to detect problems with too many objects in use and multiple parts of the code handling the same instance, they are stored in shared_ptrs and their use count is checked before returning the object. As this check fails, some part of the driver seems to request many (meaning: >1024) RsiStates.