Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sqla / database backend for beaker #15216

Closed
mvdbeek opened this issue Dec 15, 2022 · 4 comments · Fixed by #15349
Closed

Support sqla / database backend for beaker #15216

mvdbeek opened this issue Dec 15, 2022 · 4 comments · Fixed by #15349
Assignees
Labels
area/backend area/configuration Galaxy's configuration system backend/wishlist Things we want to do, but not now help wanted also "hacktoberfest", beginner friendly set of issues kind/enhancement

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Dec 15, 2022

Should help with galaxyproject/galaxy-helm#399 (comment)

@mvdbeek mvdbeek added kind/enhancement help wanted also "hacktoberfest", beginner friendly set of issues area/backend labels Dec 15, 2022
@mvdbeek mvdbeek added area/configuration Galaxy's configuration system backend/wishlist Things we want to do, but not now labels Jan 10, 2023
@claudiofr
Copy link
Contributor

claudiofr commented Jan 10, 2023

This would be my first contribution to galaxyproject. I made the code changes locally and wrote a unit test for it, but I don't believe that it will help with galaxyproject/galaxy-helm#399 (comment) because the beaker docs say that the lock_dir cache parameter is required independent of the cache type. This suggests that it uses the file system for locking even if it uses the database for the cache. I'm also relatively new to github and I'm about to do my first github pull request. I presume you need to assign it to me as I see no way to assign the issue to myself. Can you please do so?

@jdavcs
Copy link
Member

jdavcs commented Jan 10, 2023

I presume you need to assign it to me as I see no way to assign the issue to myself. Can you please do so?

Done.

@claudiofr
Copy link
Contributor

I created a pull request for this. Will someone be automatically notified of this and take action on it or do I need to explicitly notify someone?

@nsoranzo
Copy link
Member

@claudiofr Thanks, all the repository reviewers received a notification from GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend area/configuration Galaxy's configuration system backend/wishlist Things we want to do, but not now help wanted also "hacktoberfest", beginner friendly set of issues kind/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants