Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Editor: tool form view can enter into an unjustified view and reset buttons do not re-justify text #19463

Open
jennaj opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them

Comments

@jennaj
Copy link
Member

jennaj commented Jan 24, 2025

Describe the bug
In the workflow editor, editing a tool's form in the pop-up side panel can enter and unjustified view than can only be reset by closing it and starting over. Seems that the reset all stored sizes function isn't working but that is also a bit hard to find. The trigger is clicking into an option that is a bit wider than that panel. Maybe always justify left and wrap the content instead?

This either wasn't presenting in the test release testing or I missed it while reviewing -- maybe used a tool with a different type of form, not sure. This new test was using CutAdapt, so seems important to look good here.

Galaxy Version and/or server at which you observed the bug
UseGalaxy.org
This Galaxy server version is 24.2.rc1, and the web client was built on Thursday Jan 23rd 10:37:30 2025 GMT-8 .

Browser and Operating System
Operating System: Windows, Linux, macOS
Browser: Firefox, Chrome, Chrome-based, Safari

To Reproduce
Steps to reproduce the behavior:

  1. Open a workflow in the editor. Test case sourced from this GTN tutorial
  2. Click on Cutadapt to bring up the tool form in the right panel
  3. Click on the 3' adapter source drop-down
  4. See error -- no way to correct the justification: resizing larger or smaller again isn't enough (manually or with the arrows), using the gear > reset all stored sizes function doesn't seem to do anything (?).
  5. You have to close the pop-up and start over. If you made changes, those will be retained, which is good!
  6. Cutadapt forms are particularly "nested" so I had to open the pop-up as wide as it would go in order to not trigger the justification jump over to the right. This wouldn't work well on a laptop (or phone!)

Expected behavior
Either wrap the text and always left justify (best?), have the resizing arrows re-justify to the left, have the reset function re-justify, or ??

I had expected by default to find a scroll option at the bottom but maybe that was not included on purpose and those are what the arrows and resets are for instead.

Screenshots

Series going through the steps

Image

Image

Image

Image

Image

Image

Image

@jennaj jennaj added the release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them label Jan 24, 2025
@ElectronicBlueberry ElectronicBlueberry self-assigned this Jan 27, 2025
@ElectronicBlueberry
Copy link
Member

Thank you for the detailed report! This seems to be caused by the help text of this tool overflowing. Working on a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-testing-24.2 Issues stemming from 24.2 release testing process and PRs to address them
Projects
None yet
Development

No branches or pull requests

2 participants