Set default to "No" for conditional parameters in msconvert #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to be failing due to disk space. Is there an existing solution to fix CI here? |
reid-wagner
force-pushed
the
fix_msconvert_defaults
branch
2 times, most recently
from
f15d0e9 to
7a37148
Compare
reid-wagner
force-pushed
the
fix_msconvert_defaults
branch
from
7a37148 to
13d0d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between Galaxy versions .2 and .3 (#748) the default setting for these conditional parameters changed from false to true when the parameter type was changed from
booleantoselect, because of the way these two types are interpreted.I believe we want these to be off by default, which this PR implements. @bebatut - please let me know if this is incorrect. Thanks!