Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More uniform function names for heaps #25

Open
markuspf opened this issue Aug 3, 2017 · 1 comment
Open

More uniform function names for heaps #25

markuspf opened this issue Aug 3, 2017 · 1 comment

Comments

@markuspf
Copy link
Member

markuspf commented Aug 3, 2017

We should probably use uniform names for the heap-api functions such as BinaryHeap_Push and PairingHeap_Push (and by extension WhateverHeap_Push).

@fingolfin
Copy link
Member

Are these really APIs? Or rather: Do we want those to be APIs? To me, they are implementation details, which the user should not access directly.
The one reason I can think of why one might want to change that is because by making them "official", the user can conveniently bypass method dispatch. That convenience is, however, bought with us being forced to keep supporting these names indefinitely.

I'd tend to default to not doing that, and wait until somebody show us a usecase where (a) method dispatch causes a noticeable and relevant speed penalty, and (b) "manually" retrieving and using the applicable methods, using ApplicableMethods, for some reason is not a (good) solution...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants