From 3b2534b03ff6fa03a56b612d68940111c1a55aa3 Mon Sep 17 00:00:00 2001 From: Geoffrey Hunter Date: Mon, 24 Jun 2024 09:36:58 +1200 Subject: [PATCH] Fixed broken blinking cursor in homepage and manual views. --- CHANGELOG.md | 4 ++++ src/Homepage/HomepageView.css | 12 ++++++++++++ src/Homepage/HomepageView.tsx | 1 - src/Manual/ManualView.css | 12 ++++++++++++ src/Manual/ManualView.tsx | 17 ++++++++++++----- 5 files changed, 40 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4c50477..d5f23376 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Added support for the ESC[1J, ESC[2J and ESC[3J "Erase in Display" ASCII escape codes (ESC[0J was already supported). - Added a "Manual" page to the app, which contains the start of a user manual for NinjaTerm. +### Fixed + +- Cosmetic cursor at the end of the blurb now blinks again on homepage. + ### Changed - Switched from a CJS to ESM build in vite. CJS build is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more info. diff --git a/src/Homepage/HomepageView.css b/src/Homepage/HomepageView.css index f411834b..71780d85 100644 --- a/src/Homepage/HomepageView.css +++ b/src/Homepage/HomepageView.css @@ -7,6 +7,18 @@ /* height: 15px; */ } +@keyframes blink { + 0% { + background-color: #222; + } + 50% { + background-color: white; + } + 100% { + background-color: #222; + } +} + h2 { margin-bottom: 10px; } diff --git a/src/Homepage/HomepageView.tsx b/src/Homepage/HomepageView.tsx index 735fdd20..ac09ca5e 100644 --- a/src/Homepage/HomepageView.tsx +++ b/src/Homepage/HomepageView.tsx @@ -77,7 +77,6 @@ export default observer((props: Props) => { { -

NinjaTerm Manual

+ NinjaTerm Manual -

ANSI Escape Codes

+ ANSI Escape Codes

NinjaTerm supports a number of the most popular ASCII escape codes for manipulating the terminal. They are commonly used for colouring/styling text (e.g. making errors red), moving the cursor around and deleting data (e.g. clearing the screen, or re-writing an existing row). These features are very useful when making interactive prompts.

-

Erase in Display (ESC[nJ)

+ Erase in Display (ESC[nJ)

The current rows in view are ignored when performing Erase in Display commands, as the user could be viewing old data in the scrollback buffer while the cursor is still