Enhancing User Session #10657 #10712
Conversation
There was a problem hiding this comment.
-
The icon of delete is the same of the delete map. It is a pre-existing issue, but is confusing.
I'd suggest clear-brus icon for user session clean (or a custom icon). Let's wait for a confirmation from @tdipisa about this.
-
To be more clear I'd change the window as following:
- Instead of simple "Waring", insert in the title "Clear user session"
- The text should be: "Are you sure to remove the current user session? This will restore the original map/context configuration, removing your current changes. Please select what you want to remove and unselect what you want to preserve." (properly localizing strings).
- A little more margin between text and tree, to better isolate the parts (or a lightgray border for the tree)
- and button on bottom with normal size (they are giant).
Bug:
-
Inconsistent selection after closing and re-opening the window (see the video, click on everything, then close and reopen, last items are selected). Same if I save the session.
screencast-localhost_8081-2025_01_14-17_32_07.webm
- Visibility messed up on user session clean up/restore (see blue borders on layers, indicating the current seleted background. (Also checking-unchecking layers makes the background layer selection change). ALSO THIS IS PRE-EXISTING.
bug_background.webm
Here a screenshot on dev, same issue: 
- Created a map with annotation and measure layer. Clean up session just to make sure. Remove measure layer and refresh. I have 2 annotation layers. Please fix this and test better these corner cases, adding unit tests to guarantee this issue not happens. NOTE: looks to be a pre-existing bug. It happens also on DEV. JFI @tdipisa
bug_sess_measure.mp4
-
Map uses for test: https://dev-mapstore.geosolutionsgroup.com/mapstore/#/context/session_all_plugins/52242 (locally of course).
-
As discussed, please update documentation of the plugin with the new logic, fixing old phrases (partially, BurgerMenu...) and adding this to clarify the workflow
```mermaid
graph TD
S[Start] --> A
A[Load Context] -->|Override Map Config| B[Load Map]
B --> |Override partially map config| C[Load Session]
C --> |Save Session| C
C --> |Clear config| D[Clear Session]
D --> |Reload| A
```
| * @param {object} customHandlers - session Saved By registerCustomSaveHandler | ||
| * @returns {object} updated overrideConfig | ||
| */ | ||
| export const updateOverrideConfigToClean = (override, thingsToClear = [], originalConfig = {}, customHandlers = {}) => { |
There was a problem hiding this comment.
This needs some unit test alone.
|
For both developers and testers, @rowheat02 MAKE YOU SURE YOU TEST SESSION:
This is to @ElenaGallo too, when this issue will be merged in next days. |
|
@rowheat02 possibly we should try to address all reported points above. Just let me know how much time these require in your opinion, especially for pre-existing bugs: if the effort is too much we can consider opening a separated issue for them. We should possibly stay in 1pts for all requested changes above. |
|
@rowheat02 I added the doc update as discussed. |
Description
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
#10657
What is the current behavior?
Only able to save maps and featureGrid Configs and while clearing session all session used to get cleaned
#10657
What is the new behavior?
Other config like bookmarks, mapTemplates, userPlugins along with existing one gets saved and individual session can be cleared.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information