Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload images on Text widgets #10719

Closed
1 of 6 tasks
mahmoudadel54 opened this issue Dec 5, 2024 · 0 comments · Fixed by #10735
Closed
1 of 6 tasks

Upload images on Text widgets #10719

mahmoudadel54 opened this issue Dec 5, 2024 · 0 comments · Fixed by #10735
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted enhancement
Milestone
2025.01.00

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Dec 5, 2024 •
edited by tdipisa
Loading

Description

It seems no longer possible to copy/paste images in the Text widget editor. In Details there is anyway a recent function we added for uploading images which is handled by the new text editor.
The editor is the same thanks to #9627 (widgets have a different config). Some additional logic is anyway necessary to share the same codebase for both places (widgets/Details) with an enhancement.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information
@mahmoudadel54 mahmoudadel54 self-assigned this Dec 5, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 7, 2025
@mahmoudadel54
geosolutions-it#10719: enable upload images within Text widgets
df81e22 
Description:
- add 'prop' called 'enableUploadImg' passing it to 'CompactRichTextEditor' component to enable upload image
- add unit test
@tdipisa tdipisa added this to the 2025.01.00 milestone Jan 7, 2025
@mahmoudadel54 mahmoudadel54 mentioned this issue Jan 7, 2025
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Jan 7, 2025 that will close this issue
#10719: enable upload images within Text widgets #10735
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 13, 2025
@mahmoudadel54
geosolutions-it#10719: revert naming enableUploadImg to be uploadEnabled
ca8607f
MV88 pushed a commit that referenced this issue Jan 14, 2025
@mahmoudadel54
#10719: enable upload images within Text widgets (#10735)
779416d 
* #10719: enable upload images within Text widgets
Description:
- add 'prop' called 'enableUploadImg' passing it to 'CompactRichTextEditor' component to enable upload image
- add unit test

* #10719: revert naming enableUploadImg to be uploadEnabled
@ElenaGallo ElenaGallo self-assigned this Jan 14, 2025
@ElenaGallo ElenaGallo mentioned this issue Jan 14, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted enhancement
Projects
None yet
Milestone
2025.01.00
Development

Successfully merging a pull request may close this issue.

#10719: enable upload images within Text widgets mahmoudadel54/MapStore2
3 participants
@tdipisa @ElenaGallo @mahmoudadel54