Fix #10739 Changing correctly resolutions limits when switching map CRS #10746
+150
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switching map CRS
dsuren1
requested changes
Jan 15, 2025
There was a problem hiding this comment.
@MV88
I noticed the following behaviors during testing. Kindly take a look. Thanks!
-
When the visibility limits are set on projection other than the default ones (4326, 3857), switching back to 4326 causes the visibility limits to default to the maximum value for both the min and max fields. This results in the layer being perpetually hidden. This issue occurs exclusively with 4326.
Tested with 25832, 2154
"projectionDefs":[{"code":"EPSG:25832","def":"+proj=utm +zone=32 +ellps=GRS80 +towgs84=0,0,0,0,0,0,0 +units=m +no_defs","extent":[229521.4465,0,923521.4465,9329005.182],"worldExtent":[6.0,53.0,15.0,60.0]},{"code":"EPSG:2154","def":"+proj=lcc +lat_1=49 +lat_2=44 +lat_0=46.5 +lon_0=3 +x_0=700000 +y_0=6600000 +ellps=GRS80 +towgs84=0,0,0,0,0,0,0 +units=m +no_defs","extent":[-378305.81,6093283.21,1212610.74,7186901.68],"worldExtent":[-9.86,41.15,10.38,51.56]}]
crs_to_4326.mp4
-
When setting visibility limits on EPSG:4326 and previewing the print map, the layer is hidden in the print preview when the CRS is EPSG:3857. However, it works correctly when the CRS is EPSG:4326 in the print tool
print-crs-4326.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are changing resolutions also in the view because these were not aligned to the layers especially when switching to 4326. ol map view was having a different list causing a misalignment between current resolution and zoom level
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10739
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information