Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action to avoid to do publish for local version #342

Open
offtherailz opened this issue Mar 5, 2024 · 2 comments
Open

Fix action to avoid to do publish for local version #342

offtherailz opened this issue Mar 5, 2024 · 2 comments
Labels

Comments

@offtherailz
Copy link
Member

Actually PR done from local branch pushish anyway.
Publish should be possible only on release and master branches.

@offtherailz offtherailz added the bug label Mar 5, 2024
@offtherailz offtherailz added this to the 2024.01.00 milestone Mar 5, 2024
@offtherailz offtherailz self-assigned this Mar 5, 2024
@offtherailz
Copy link
Member Author

offtherailz commented Mar 21, 2024

After a check the issue is very limited. I opened this issue because I noticed that this PR triggered a publish on push

Image

Anyway the problem was that we had a branch called 2.1-c125 and this was matching the regular expression [0-9]+.[0-9]+* [0-9]+.[0-9]+* that run on push, that does "CI" checks + publishing, if the push is on the main repository.

Now, we can think enforce the publish condition, anyway the problem is more limited than expected and can be postponed imho.
(working on the fule for publish is a little more complicated that the regex).

@tdipisa tdipisa removed this from the 2024.01.00 milestone Mar 22, 2024
@tdipisa
Copy link
Member

tdipisa commented Mar 22, 2024

@offtherailz got it. Thank you for checking. If so, let's remove this issue from the milestone 2024.01.00.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants