Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proxmox Backup Server Widget] Add support for specifying a datastore #4614

Closed
wants to merge 2 commits into from

Conversation

choehn86
Copy link

Proposed change

Implements changes to accommodate this feature request.

PBS datastore configuration:
PBS

Example services.yaml specifying 'local-backups' datastore:

- Proxmox Backup Server:
    href: https://pbs.domain
    description: Proxmox Backup Server
    widget:
      type: proxmoxbackupserver
      url: https://pbs.domain
      username: homepage@pbs!api
      password: apikey
      datastore: "local-backups"

Result:

Widget-local-backups

Example services.yaml without datastore key:

- Proxmox Backup Server:
    href: https://pbs.domain
    description: Proxmox Backup Server
    widget:
      type: proxmoxbackupserver
      url: https://pbs.domain
      username: homepage@pbs!api
      password: apikey

Result is the combination of all datastores used / total:

Widget-all

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature / enhancement and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

Changed to accommodate multiple datastores or a specific datastore supplied in services.yaml
Implemented datastore key for proxmoxbackupserver widget
@shamoon
Copy link
Collaborator

shamoon commented Jan 16, 2025

There are 2 votes on that FR, you and the other user. Let's make sure theres a bit more interest before reviewing this. We can readdress in the future, thanks

@shamoon shamoon closed this Jan 16, 2025
@choehn86
Copy link
Author

choehn86 commented Jan 17, 2025

@shamoon Is it worth taking a second look from a bug-fix perspective? Today anyone using the widget who has >1 datastore will get inconsistent monitoring due to the widget being hard-coded to always look at the first entry in the result set, while the PBS API doesn't explicitly return the datastores in a particular order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants