Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing schema validation for safe-settings. #719

Open
decyjphr opened this issue Dec 25, 2024 · 1 comment
Open

Doing schema validation for safe-settings. #719

decyjphr opened this issue Dec 25, 2024 · 1 comment

Comments

@decyjphr
Copy link
Collaborator

@jonathanmorley had raised a PR #689 to merge JSON schema for validating settings.yml. This is a great start! And @luvsaxena1, @zpratt, @primetheus, have also done various implementations of schema validation checks in their environments to catch errors in the settings yaml -- in the IDE or during the PR check.

I am new to this and I've been looking through the docs for Zod (Which Zach has been using) and AJV (Which I found via search).

I created this issue to allow us to collaborate and take their work and have some sort of schema validation in safe-settings.

@primetheus
Copy link
Contributor

primetheus commented Jan 8, 2025

@decyjphr I looked at ajv, but I haven't seen zod. Ours is built using openapi-request-validator, but we're hitting an issue with the rulesets due to an issue with traversing $ref in the enforcement in @octokit/openapi schemas. I'm definitely interested in seeing how others are handling rulesets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants