Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR comment / dry-run is processed twice after pushing additional commit after initial PR #737

Open
wernerb opened this issue Jan 9, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@wernerb
Copy link

wernerb commented Jan 9, 2025

Problem Description

What is actually happening

If you create a PR it would process as normal. If you then create another commit, the logs show that it is actually listing all the repositories twice. It also results in two new PR comment to be created instead of one.

Because environments are also not processed in dry-run, as part of processing it does a DELETE and because the event is processed twice, a second DELETE appears with a 404 crashing the pod.

What is the expected behavior

A new commit would just process a single time and create a single new PR comment

Error output, if available

I can see it is processing twice by seeing that the pages of github repo call are duplicated in the logs

Context

Are you using the hosted instance of probot/settings or running your own?

If running your own instance, are you using it with github.com or GitHub Enterprise?

Version of probot/settings

Version of GitHub Enterprise

@wernerb wernerb added the bug Something isn't working label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant