Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/pprof: map allocation runtime frames no longer hidden in 1.24 #71174

Closed
prattmic opened this issue Jan 8, 2025 · 2 comments
Closed
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@prattmic
Copy link
Member

prattmic commented Jan 8, 2025

runtime/pprof hides "runtime" frames in heap profiles, so allocations in maps appear at the map assignment location in the calling code, but not in runtime.mapassign itself.

As you can see, runtime/pprof is defining "runtime frames" as symbols starting with runtime., but much of the new map implementation is in internal/runtime/maps., so frames inside the map implementation are still appearing.

@prattmic prattmic added NeedsFix The path to resolution is known, but the work has not been done. release-blocker compiler/runtime Issues related to the Go compiler and/or runtime. labels Jan 8, 2025
@prattmic prattmic added this to the Go1.24 milestone Jan 8, 2025
@prattmic prattmic self-assigned this Jan 8, 2025
@gabyhelp
Copy link

gabyhelp commented Jan 8, 2025

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/641775 mentions this issue: runtime/pprof: hide map runtime frames from heap profiles

@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Development

No branches or pull requests

3 participants