Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/rsa: TestEverything failures for "d too small" #71185

Closed
gopherbot opened this issue Jan 8, 2025 · 6 comments
Closed

crypto/rsa: TestEverything failures for "d too small" #71185

gopherbot opened this issue Jan 8, 2025 · 6 comments
Assignees
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jan 8, 2025

#!watchflakes
default <- pkg ~ `crypto/rsa` && test ~ `TestEverything` && `d too small`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestEverything/33
=== PAUSE TestEverything/33
=== CONT  TestEverything/33
    rsa_test.go:198: GenerateKey(33): crypto/rsa: d too small
--- FAIL: TestEverything/33 (0.09s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 8, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "crypto/rsa:gofips140" && test == "TestEverything/33"
2025-01-07 07:44 go1.24-linux-amd64-longtest-aliastypeparams release-branch.go1.24@27c51643 crypto/rsa:gofips140.TestEverything/33 (log)
=== RUN   TestEverything/33
=== PAUSE TestEverything/33
=== CONT  TestEverything/33
    rsa_test.go:198: GenerateKey(33): crypto/rsa: d too small
--- FAIL: TestEverything/33 (0.09s)

watchflakes

@FiloSottile FiloSottile changed the title crypto/rsa:gofips140: TestEverything/33 failures crypto/rsa: TestEverything failures for "d too small" Jan 9, 2025
@FiloSottile FiloSottile self-assigned this Jan 9, 2025
@FiloSottile FiloSottile added this to the Go1.24 milestone Jan 9, 2025
@FiloSottile
Copy link
Contributor

This is probably just an issue with ordinarily impossible things being possible for toy-sized keys.

@FiloSottile
Copy link
Contributor

I can reproduce the flakes with godev test crypto/rsa -run TestEverything/^34$ -count 10000.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/641755 mentions this issue: crypto/rsa: fix GenerateKey flakes for toy-sized keys

@gopherbot

This comment was marked as resolved.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `crypto/rsa` && test ~ `TestEverything` && `d too small`
2025-01-08 17:25 go1.24-linux-amd64-longtest-race release-branch.go1.24@f025d19e crypto/rsa.TestEverything/34 (log)
=== RUN   TestEverything/34
=== PAUSE TestEverything/34
=== CONT  TestEverything/34
    rsa_test.go:198: GenerateKey(34): crypto/rsa: d too small
--- FAIL: TestEverything/34 (0.05s)

watchflakes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 9, 2025
@dmitshur dmitshur moved this to Active in Test Flakes Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Status: Done
Development

No branches or pull requests

3 participants