Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme/autocert: Manager.GetCertificate should check host policy before consulting cache #71199

Open
rolandshoemaker opened this issue Jan 9, 2025 · 0 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Security
Milestone

Comments

@rolandshoemaker
Copy link
Member

Manager.GetCertificate doesn't check the host policy if the request is a challenge, probing the cache if there isn't an entry in the certTokens map. While cache probes should be cheap, an attacker may exploit any latency introduced by these probes by forcing repeated cache misses.

This can be fixed by simply moving the host policy check above the cache probe, which is likely to be cheaper, if implemented, than a cache probe.

This is a PUBLIC track security issue, due to its minimal impact.

Thanks to Dimitri Stiliadis for reporting this issue.

@rolandshoemaker rolandshoemaker added Security NeedsFix The path to resolution is known, but the work has not been done. labels Jan 9, 2025
@gopherbot gopherbot added this to the Unreleased milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Security
Projects
None yet
Development

No branches or pull requests

2 participants