Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dead_code warnings on various slides #2558

Open
fw-immunant opened this issue Jan 16, 2025 · 1 comment
Open

dead_code warnings on various slides #2558

fw-immunant opened this issue Jan 16, 2025 · 1 comment
Assignees

Comments

@fw-immunant
Copy link
Collaborator

Now that we see stderr, warnings for dead code are visible on quite a few slides. In just about every case we do want the dead code to be present because it has didactic value. We should add #![allow(dead_code)] where appropriate or pass the corresponding flag to rustc if the sandbox allows that.

@djmitche
Copy link
Collaborator

We noticed this during instruction this week as well. I'll see if we can fix it up. Another option may be to include it but hidden (some slides appear to have hidden code, and I'm not sure how that works!)

@djmitche djmitche self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants