Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior with mdbook serve compared to published version. #2588

Open
andriyDev opened this issue Jan 25, 2025 · 3 comments
Open

Incorrect behavior with mdbook serve compared to published version. #2588

andriyDev opened this issue Jan 25, 2025 · 3 comments

Comments

@andriyDev
Copy link
Contributor

andriyDev commented Jan 25, 2025

Using mdbook serve locally (following the instructions in the README) is quite different from the version on https://google.github.io/comprehensive-rust.

  1. There's no theme or search button.
  2. Clicking on a lesson (e.g., Control Flow Basics > break and continue) does not "expand" the appropriate section in the side bar.
  3. Links don't "reset" correctly. For example, viewing Control Flow Basics > break and continue, then clicking Tuples and Arrays in the sidebar results in a Document not found page (it is trying to access localhost:3000/control-flow-basics/tuples-and-arrays.html).

This was on Chrome. I also tried it on Firefox (with no extensions) to the same end result. I am serving from a Linux laptop.

@djmitche
Copy link
Collaborator

I've seen this as well, and assumed it was something I'd done wrong. This started with #2547 but that was reverted in #2564. I assume it has to do with conflicting versions of various mdbook-* packages installed locally, compared to those expected by the repo contents.

@andriyDev
Copy link
Contributor Author

How do I know which versions are the right ones? I ran the --locked commands in the README, so I'd assume it should install the same versions as in this repo? (perhaps that's wrong)

@andriyDev
Copy link
Contributor Author

Ah looks like downgrading mdbook to 0.4.37 (to match the Github Workflow) seems to have worked. All the features now work correctly.

Should we include this in the README instructions? I might need to report this to mdbook-svgbob or something as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants