Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support <scheme>.sub_plain for OpenFHE backend #1200

Closed
AlexanderViand-Intel opened this issue Dec 16, 2024 · 3 comments · Fixed by #1292
Closed

Support <scheme>.sub_plain for OpenFHE backend #1200

AlexanderViand-Intel opened this issue Dec 16, 2024 · 3 comments · Fixed by #1292
Labels
dialect: openfhe Issues related to the openfhe dialect good first issue Good for newcomers

Comments

@AlexanderViand-Intel
Copy link
Collaborator

Currently, we have bgv.sub_plain and ckks.sub_plain but no way to target them to OpenFHE
@AlexanderViand-Intel AlexanderViand-Intel added the dialect: openfhe Issues related to the openfhe dialect label Dec 16, 2024
@asraa
Copy link
Collaborator

asraa commented Dec 16, 2024

I think OpenFHE's EvalMul and EvalAdd are overloaded to support ciphertext-ciphertext and ciphertext-plaintext

@AlexanderViand-Intel
Copy link
Collaborator Author

I think OpenFHE's EvalMul and EvalAdd are overloaded to support ciphertext-ciphertext and ciphertext-plaintext

Yep, and those the pipeline already supports. But I'm not sure its supported for EvalSub in OpenFHE? If not, that just means we need to translate it to "negate plaintext, then add" (assuming that's the direction the op is defined in, which I don't recall right now 🙈 )

@asraa
Copy link
Collaborator

asraa commented Dec 16, 2024

Oh! Gotcha - I think you're right about that and having some kind of rewrite/canonicalization pattern.

@AlexanderViand-Intel AlexanderViand-Intel added the good first issue Good for newcomers label Dec 19, 2024
copybara-service bot pushed a commit that referenced this issue Jan 22, 2025
@asraa @copybara-github
Add openfhe sub plain operation
193ded2 
Fixes #1200

Seems like openfhe does expose an overload to EvalSub that allows ct-pt.

PiperOrigin-RevId: 718504746
@copybara-service copybara-service bot mentioned this issue Jan 22, 2025
Merged
copybara-service bot pushed a commit that referenced this issue Jan 23, 2025
@asraa @copybara-github
Add openfhe sub plain operation
7c33c8a 
Fixes #1200

Seems like openfhe does expose an overload to EvalSub that allows ct-pt.

PiperOrigin-RevId: 718504746
copybara-service bot pushed a commit that referenced this issue Jan 24, 2025
@asraa @copybara-github
Add openfhe sub plain operation
4b27484 
Fixes #1200

Seems like openfhe does expose an overload to EvalSub that allows ct-pt.

PiperOrigin-RevId: 718504746
copybara-service bot pushed a commit that referenced this issue Jan 24, 2025
@asraa @copybara-github
Add openfhe sub plain operation
64322c4 
Fixes #1200

Seems like openfhe does expose an overload to EvalSub that allows ct-pt.

PiperOrigin-RevId: 718504746
copybara-service bot pushed a commit that referenced this issue Jan 24, 2025
@asraa @copybara-github
Add openfhe sub plain operation
1e126c2 
Fixes #1200

Seems like openfhe does expose an overload to EvalSub that allows ct-pt.

PiperOrigin-RevId: 718504746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dialect: openfhe Issues related to the openfhe dialect good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add openfhe sub plain operation google/heir
2 participants
@asraa @AlexanderViand-Intel