Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use the" y_eval" of the tuning parameter as the test set for evaluation, shouldn't it be separate? #12

Open
maymodric opened this issue Mar 23, 2024 · 1 comment

Comments

@maymodric
Copy link

No description provided.

@Ty4Code
Copy link

Ty4Code commented Apr 3, 2024

I totally agree, it is likely not a good idea in general to use the test set as our 'validation_data' input for the TensorFlow fit function.

However, in this particular case, I don't think it's an issue because there is no early stopping and the validation loss is not used for any hyperparameter tuning.

In other words, if we were to remove the validation_data=(x_eval, y_eval) line from the notebook, it would not have any impact on the final results of the training run/notebook run as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants