Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to grade-upload and refactor glues #9

Open
fabiosimeoni opened this issue Feb 5, 2015 · 3 comments
Open

migrate to grade-upload and refactor glues #9

fabiosimeoni opened this issue Feb 5, 2015 · 3 comments

Comments

@fabiosimeoni
Copy link
Member

the dsl initially implemented in grade-glue is now generalised and extracted into standalone client API for java clients, grade-upload. We need now to further refactor to use it.

also, the current distribution of tests across source files hides the overall integration picture. Id' like to move all tests to Glues, as per the original design, and maintain separate fils for source-specific post-processing steps invoked directly from the tests in Glues. These files can go in an aux package.

finally, the use of constants and utils can be more systematic and symmetric across sources. I'm including that too in the refactoring.

@eblondel
Copy link
Contributor

eblondel commented Feb 5, 2015

It sounds good, i like the idea to have all grab and push methods in a single Glues but indeed keeping all post-processing methods clustered by source/theme, as we have now.

@fabiosimeoni
Copy link
Member Author

pushed it, please check it out. any question is welcome here. will close when you give the thumbs up.

@eblondel
Copy link
Contributor

I've investigated how to add a loadFeatures from local GML file in Commons. At now, reading GML requires to have access to the featureType. Considering the need to have atomic grab / push methods, and possible to face ows server unavailability, we should have the capacity to read local GML files vs. the GeoAPI, to reuse for post-processing and pushing. At now it's not possible with Geotk, but they reported they are working on a GMLFeatureStore that would be make this possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants