compute: allow "instance" label name to be set (behind a flag) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #262. *## What Allow `instance` label name to be set via new `-compute.instance-label` flag. *## Why See #262 for the rationale and discussion. *## How * for each compute `Collector`, create new `collectorMetrics` type containing compute metrics (moved from _global var_), to let each `Collector` own an allocated instance obtained via `newCollectorMetrics(instanceLabel)` * changing metrics from _global var_ to dynamically allocated object is needed for: * setting its label at runtime * allowing tests to be self-contained, else the 1st test to run would "own" setting `instanceLabel` * there's a new `config.CommonConfig` type, currently only having a single field `ComputeInstanceLabel`, which is passed down from `cmd/` to each instantiated _Provider_, then to each compute _Collector_ *## Testing Adapted testing with a couple `ComputeInstanceLabel="node"` changes, although it should be improved to test changes to the label name. -- Signed-off-by: JuanJo Ciarlante <[email protected]>
|
BTW also manually tested it locally with: |
jjo
changed the title
Signed-off-by: JuanJo Ciarlante <[email protected]>
|
Closing as this was intended as a PoC / exploration to sense the feasibility and complexity on adding such flag, then we also agreed on not moving fwd with this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262.
What
Allow
instancelabel name to be set via new-compute.instance-labelflag.Why
See #262 for the rationale and discussion.
How
for each compute
Collector, create newcollectorMetricstypecontaining compute metrics (moved from global var), to let each
Collectorown an allocated instance obtained vianewCollectorMetrics(instanceLabel)changing metrics from global var to dynamically allocated object is
needed for:
instanceLabelspot={true,false}labelthere's a new
config.CommonConfigtype, currently only having asingle field
ComputeInstanceLabel, which is passed down fromcmd/to each instantiated Provider, then to each compute Collector
Testing
Adapted testing with a couple
ComputeInstanceLabel="node"changes,although it should be improved to test changes to the label name.
--
Signed-off-by: JuanJo Ciarlante [email protected]