-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Helm Chart for cloudcost-exporter #392
Comments
@nikimanoledaki do you think we should create a repo specific to the helm chart? I've seen a mixture of patterns out in the OSS community. We could always start with a helm chart within this repo and expand. |
We could use the Helm chart repository that is maintained under the Grafana organization, create a new |
I wonder why the k8s-monitoring team opted to create their own repo: https://github.com/grafana/helm-charts/tree/main/charts/k8s-monitoring, https://github.com/grafana/k8s-monitoring-helm? Do you mind reaching out in #k8s-monitoring to get a bit more context? That should help us make a more informed opinion on sticking with the grafana |
Very good point - I hadn't seen that 👀 Will investigate and report back! |
Helm Chart repository & git repositoryGrafana Labs products use the https://grafana.github.io/helm-charts Helm chart repository. This can be validated with the following (which is also where cloudcost-exporter should be added):
Apps that are maintained by both GL and the community are also listed in this helm chart repository, such as The most common pattern that I found is for the source code of the helm chart to live in the same git repository as the rest of the application's source code. Examples:
It seems that the For our use case, let's bootstrap the helm chart in this repo. Keeping things in this repo will help with reviews and creating changes in both the app's source code and the Helm chart at the same time if needed which would be faster than two separate repos. Added a TODO to the description - might turn the TODO list into sub-issues as I go along |
Thanks @nikimanoledaki for the research!
That works for me. As always, if we find it problematic, then we can move to helm chart over to a dedicated repository. |
The Helm chart lives in this branch: https://github.com/grafana/cloudcost-exporter/tree/nm/add-helm-chart Next steps:
|
Feature Request
Issue to add a Helm Chart for cloudcost-exporter ✨
Acceptance Criteria
TODO
grafana/cloudcost-exporter
repografana/helm-charts
e.g. https://github.com/grafana/helm-charts/tree/main/charts/cloudcost-exportergrafana/helm-charts
e.g. https://github.com/grafana/helm-charts/releases/tag/k8s-monitoring-2.0.2 - workflowhelm search repo grafana
The text was updated successfully, but these errors were encountered: