Upgrade plugin to work with actual newest ES version 6.5.x

[occurred]

For this also an upgrade from the actual used TransportClient to the new Rest Client will be done:
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/master/java-rest-overview.html

[codeconsole]

You are better off skipping 6.5.x and going straight to 7.1.x

[cgoIT]

Are there any plans to get this issue done in an upcoming release (2.5.0, 2.6.0)? We're using this plugin in one of our projects but have to use a newer es version. We have some little time yet. But if there is no time schedule maybe we have to get this done on our own (I think the main work is done by the commits linked here in this ticket).

[occurred]

Yes, I think the main work is already done by me, see:
https://github.com/puneetbehl/elasticsearch-grails-plugin/tree/2.6.0.RC1

Sorry, but currently I can't say when I'm able to finish.

[cgoIT]

Thx for your quick response. I saw this branch. Just looking at it ;).

Do you have a list of things which are not finished yet? I do not want to promise too much, but maybe I find the time to take a look.

[occurred]

I'll try to find out asap and will let you know - don't think that it will be before today evening (CEST).
I also saw now on my local branch that I've some small additional changes I can commit.

[cgoIT]

Hi, maybe you could have a look on my commits from today: https://github.com/cgoIT/elasticsearch-grails-plugin/commits/2.6.0.RC1.

Maybe it's easier (to not blow up this thread here) to communicate via email ([email protected]) and post our results here?

[cgoIT]

I also invested some time to upgrade to ElasticSearch 7.3.0. You could find my commits under https://github.com/cgoIT/elasticsearch-grails-plugin/commits/2.7.0.RC1.

In this branch I also included a gradle plugin (the plugin is not available at the plugin portal right now. Will be there soon) to start an "embedded" elasticsearch node for integration tests.

[puneetbehl]

Thank you @cgoIT and @occurred for your help. I just completed an initial draft to support Grails 4. Also, we are now using semantic versioning ( trying to simplify versioning). So, the next version to support Grails 4 would be 3.0.0

Once we complete upgrade to support ES 6.x or 7.x then the version would be 5.0.0. I am going on vacation but will prioritize the remaining work to support ES v7.3.0.

[puneetbehl]

@cgoIT Would you be interested to send a PR with your changes?

[cgoIT]

Hi, this could be difficult. In the meantime, a lot of code has changed, so that merging should no longer be possible automatically.

I don't think the situation itself is really good, but since we have to use the plugin in an official product, we were forced to develop it further.

Currently I have too little time to rework the code so that am automatic merge is possible. Unfortunately I didn't get any feedback on my messages from 6.8. and 8.8.2019. Otherwise I surely would have waited with the further adjustments.

There are not only the adjustments to the new ElasticSearch version. The other main changes concern the possibility to use aggregations and the Snapshot Lifecycle Management.

[puneetbehl]

I appreciate the effort you put in and all the work you have done on the plugin. I think the issue might be that you are trying to merge to the master branch which is for Grails 4. The automatic merge should be possible without conflicts if you do it based on the branch 2.6.0.RC1.

Once, that is done I would add a tag and that should do the automatic release to support the latest version of Elasticsearch with Grails 3. If you would want the commit rights on this repository then I could grant the permission for the same. But, I would like to keep this as the official repository.

[puneetbehl]

Check https://github.com/puneetbehl/elasticsearch-grails-plugin/tree/2.7.x
Thanks to @cgoIT and @occurred

[cgoIT]

Hi,
maybe you could have a look at #14 and #15. I think there's a good chance that this two bugs are fixed as well with the new version.

#14: I'm not sure if I get all cases for Temporal classes from the java.time package.
#15: I use highlighting feature quite intensive within our application and didn't found any issues with that until now.