Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny Sender by default over Allow by default #301

Open
gusinacio opened this issue Aug 22, 2024 · 0 comments
Open

Deny Sender by default over Allow by default #301

gusinacio opened this issue Aug 22, 2024 · 0 comments
Labels
p3 Low priority pgk:tap-agent repo:indexer-rs size:x-large Very large tap type:refactor Changes not visible to users

Comments

@gusinacio
Copy link
Member

We don't have a tap-aggregator resolver for senders so indexers must manually provide a list of sender accounts they recognize as trustful.

Currently, when a new sender decides to deposit to Escrow, tap-agent identifies it and denies it. But it makes more sense to deny all senders by default and have an "allow list" of senders with the correct tap-agent "SenderAccount" set up correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 Low priority pgk:tap-agent repo:indexer-rs size:x-large Very large tap type:refactor Changes not visible to users
Projects
None yet
Development

No branches or pull requests

1 participant