Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that extra keys in the request/response payloads are not allowed #271

Closed
benjie opened this issue Oct 27, 2023 · 2 comments · Fixed by #278
Closed

Make it clear that extra keys in the request/response payloads are not allowed #271

benjie opened this issue Oct 27, 2023 · 2 comments · Fixed by #278
Assignees
@benjie

Comments

@benjie
Copy link
Member

benjie commented Oct 27, 2023

This is a task for myself really.

The extensions object exists so that vendors may add their own properties to requests/responses/errors/etc. All top-level keys are reserved by the spec. We should make this explicit, such that adding id as a key to a request automatically makes the request not a GraphQL-over-HTTP request. (Which is fine, because the server is still allowed to handle it however it sees fit.)
@benjie benjie self-assigned this Oct 27, 2023
@benjie
Copy link
Member Author

benjie commented Oct 27, 2023

(This relates to @martinbonnin's comments here: #264 (comment))

@benjie benjie mentioned this issue Oct 27, 2023
Merged
@benjie
Copy link
Member Author

benjie commented Oct 27, 2023

Closing in favour of #278

@benjie benjie closed this as completed Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjie benjie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it clear that other keys are reserved graphql/graphql-over-http
1 participant
@benjie