Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 14 incompatibility #23

Open
stfp opened this issue Mar 31, 2021 · 3 comments · May be fixed by #24
Open

node 14 incompatibility #23

stfp opened this issue Mar 31, 2021 · 3 comments · May be fixed by #24

Comments

@stfp
Copy link

stfp commented Mar 31, 2021

We have a script that uses sass-inline-svg which fails when run with node 14

The error you get is pretty misleading: Error: error in C function svg-icon: Expected just one argument

This is actually due to something somewhere breaking this switch/case

In node 14, you just get '[object Object]', so the switch/case defaults and we end up triggering the error above.

Using util.inspect(value) instead seems to work:

switch (util.inspect(value)) {
      case 'SassMap {}':
        value = mapToObj(value);
        break;
      case 'SassColor {}':
stfp added a commit to stfp/sass-inline-svg that referenced this issue Mar 31, 2021
@stfp
Copy link
Author

stfp commented Mar 31, 2021

Others have seen this: palantir/blueprint#4415

@WalterWeidner
Copy link

WalterWeidner commented Apr 28, 2021

Any update on this? We are running into this problem on Node 14 as well.

@djragsdale
Copy link

This is a pretty big issue. The only Node version which can run this reaches End-Of-Life in 7 months. Is there any way this fix can be prioritized higher?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants