Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js-options field so that user-defined options can be passed to javascript preprocessor #10721

Open
Swordlash opened this issue Jan 6, 2025 · 2 comments
Assignees

Comments

@Swordlash
Copy link

Describe the feature request
See the GHC ticket and description of the issue: https://gitlab.haskell.org/ghc/ghc/-/issues/25632#note_602729

There seems to be currently no way to pass JS CPP options for js-sources, like defining your own macros.

Additional context
This would enable things like TRACE flags in libraries that conditionally compile logging directives, for instance.

@Mikolaj
Copy link
Member

Mikolaj commented Jan 6, 2025

Is this a newcomer ticket (if so, let's label it so), or can there be anything tricky, either in implementation or testing (I guess no testing is possible at all with our current CI?)?

@Swordlash
Copy link
Author

@Mikolaj Looks easy enough, can you assign me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants