-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make transition from sitewise LDAP on Multisite easier #140
Comments
A note about this in the changelog or readme would be great as well... Will the old config be used again if I revert to v1.5.1? |
I‘m sorry for the inconvenience. Though there is a note in the Changelog: „This new release adds Multi-Site support. It will no longer be possible to use this plugin just in one subsite of a multisite installation!“ Though the revert to 1.5.1 should have re-used the old config... I‘m investigating that!!! |
Thanks for the quick feedback, much appreciated. But maybe this loss is my fault. Is/was the config stored in the database or in a file local to the plugin? |
That‘s right. As I wrote the changelog I wasn‘t aware that that might happen. And it should actually not be lost as the config is stored in the database. And the Multisite Plugin just looks at a different place for the config. There is nonroutine to delete the config. That‘s what actually worries me a bit.... I‘ll get back to you as soon as I find a solution!! |
This is what I have in my
Looks like the default. However I also have a table |
I assume that the There is the PR #141 open, that contains a possible fix. Would you mind checking whether that actually fixes the issue? Or did you already remove the entry from the I'd be really thankful for your insights! |
WIth your patch the configuration page does not show up at all anymore, not in the site-specific settings (as in 1.5.1), nor in the network settings (2.0.0) :/ Originally I installed & enabled the plugin globally for the network, but configured each page separately. Might that cause issues? |
With the new version 2.0.3 that should work. I tested it on a local setup and I could enable the plugin site-wide and had to edit the config in the single sites… Can you confirm that? |
So, there's a bit of an issue in 2.0.3. When you upgrade to authLdap 2.0.3 in a multisite install that had been previously upgraded to 2.0 and previously from 1.5, the authLdap setting menu disappears completely from the network settings page ( I think this is because you're checking for a whether it's a multi-site install by checking for the existence of an Deleting that legacy entry from the I'm not really sure what the code fix for this would be. But I wanted to post here to note the issue. |
That was the idea! As it's been a sitewise configuration before 2.0 the main idea was to bring back the sitewise configuration for Multisite-installs from the before-2.0 era. When you delete the database-entry for Enabling a network configuration within such a pre-2.0 multisite-intallation via the admin-interface is on the roadmap for the upcoming versions. See #145 |
When old LDAP-Plugin (pre 2.0.0) was used within a multisite environment updating to 2.0 is a PITA as the config is lost.
So it would be great to have the possibility to enable a "legacy"-mechanism that will still allow the plugin to be used like before…
The text was updated successfully, but these errors were encountered: