Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-completing a variable with phpactor LSP results in two dollar signs #12544

Open
danrot opened this issue Jan 15, 2025 · 1 comment
Open
Labels
C-bug Category: This is a bug

Comments

@danrot
Copy link

danrot commented Jan 15, 2025

Summary

I am using phpactor as a PHP language server, and I have set it up as described in https://github.com/helix-editor/helix/wiki/Language-Server-Configurations#phpactor.

Whenever I type $, which indicates the use of a variable, I get the correct suggestions. However, the language server also starts the name of the variable with a $, and when choosing one of those, then I'll end up with two $ instead of just one.

Since this is correctly working in neovim, I guessed that this is an issue with helix.

Reproduction Steps

https://asciinema.org/a/cDsdxP9byICH7nexZ0i16YDv0

I would have expected to only see $variable instead of $$variable in line 5.

Helix log

~/.cache/helix/helix.log
2025-01-15T13:32:00.558 helix_lsp::transport [ERROR] phpactor err <- "Starting language server, use -vvv for verbose output\n"

Platform

macOs

Terminal Emulator

kitty 0.38.1

Installation Method

brew

Helix Version

helix 25.1 (dabfb6c)

@danrot danrot added the C-bug Category: This is a bug label Jan 15, 2025
@danrot
Copy link
Author

danrot commented Jan 16, 2025

What I forgot to mention: I also stumbled upon this issue from another repository, which sounds very familiar: yegappan/lsp#130 (comment)

Is it possible that this textEdit feature, in particular the range part, is currently also not implemented in helix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

1 participant