Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement right-clicking on the status item? #3

Open
jessesquires opened this issue Apr 9, 2020 · 1 comment
Open

Re-implement right-clicking on the status item? #3

jessesquires opened this issue Apr 9, 2020 · 1 comment
Assignees
Labels
enhancement General improvements

Comments

@jessesquires
Copy link
Member

jessesquires commented Apr 9, 2020

twitter thread:
https://twitter.com/iSapozhnik/status/1247618147785609223

See:

Also relevant:

"BTW the reason why NSMenu did not show up when you do a right-click is because while consuming this NSEvent you are just setting it. If a menu would have been set upfront-it will work"

@jessesquires jessesquires self-assigned this Apr 9, 2020
@jessesquires jessesquires added enhancement General improvements and removed feature request labels Apr 9, 2020
@jessesquires jessesquires added this to the NEXT milestone Jan 9, 2024
@jessesquires jessesquires removed this from the 2.0.0 milestone Jan 27, 2024
@jessesquires
Copy link
Member Author

Interesting update: https://mas.to/@avidrissman/113725576408899638

@jsq @mjtsai As followup to your 2019 🐦 post (1162075093469736960) about right click actions for NSStatusBarButton, where every other right-click leaves a highlight, Chrome is going to need a right-click menu so I looked at it and it seems solvable with a bit of targeted swizzling. See https://crrev.com/c/6125973 for my attempt. I’m doing some testing on older OSes and my reviewers are out for the holidays, but if you still are looking for an answer for the issue this seems like it can be fixed.

https://chromium-review.googlesource.com/c/chromium/src/+/6125973

https://chromium-review.googlesource.com/c/chromium/src/+/6125973/4/chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements
Development

No branches or pull requests

1 participant