You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
[A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]](asynq: pid=40565 2024/12/21 13:38:01.521847 ERROR: Failed to close redis client connection: redis connection is shared so the Client can't be closed through asynq)
Describe the solution you'd like
func (srv *Server) Shutdown() {
srv.state.mu.Lock()
if srv.state.value == srvStateNew || srv.state.value == srvStateClosed {
srv.state.mu.Unlock()
// server is not running, do nothing and return.
return
}
...
srv.wg.Wait()
if !srv.sharedConnection {
srv.broker.Close()
}
func (s *Scheduler) Shutdown() {
s.state.mu.Lock()
....
s.wg.Wait()
s.clearHistory()
// if sharedConnection did not close it
if err := s.client.Close(); err != nil {
s.logger.Errorf("Failed to close redis client connection: %v", err)
}
s.logger.Info("Scheduler stopped")
}
It can close redis connect after that
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered:
I'm always frustrated when...redis connection is shared so the Client can't be closed through asynq
I assume you are talking about the bug affecting the Scheduler (See #975)? Try v0.25.1 if so.
I think is not the same, I was use NewSchedulerFromRedisClient create Scheduler, it is also shareconnection. But i want shutdown Scheduler before close share connection, It will post the error msg.
Is your feature request related to a problem? Please describe.
[A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]](asynq: pid=40565 2024/12/21 13:38:01.521847 ERROR: Failed to close redis client connection: redis connection is shared so the Client can't be closed through asynq)
Describe the solution you'd like
It can close redis connect after that
Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: