fix (fungible-token): add contract-caller as allowed sender #21
+1,349
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinJanssen
approved these changes
Feb 26, 2024
|
Hi @friedger, this is great! My apologies for the delay in getting this merged. Would you mind resolving the conflict in |
|
I resolved conflicts and merged the changes here: #28 Thanks for your contribution! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the fungible-token.clar contract. It
Reasoning:
Currently, a defi contract would need to use
(as-contract (contract-call? token transfer...))if the defi contract wants to transfer own tokens. This is dangerous because it changes the sender context to the contract itself and gives the token contract access to all assets owned by the contract.It is more secure to allow the defi contract to transfer the token as
contract-caller. With this PR, an example defi.clar contract was added that allows to release tokens from the contract by any user. The user can transfer only the token itself, no other tokens might be transferred. This enables AMM without whitelisting contracts.