Call really_destroy! in validate_roles, to not throw error when role … #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njaeggi
commented
Dec 30, 2024
| it "is valid with membership in different section active since today" do | ||
| create_role(:matterhorn_mitglieder, "Mitglied", start_on: Time.zone.today) | ||
| expect(switch).to be_valid | ||
| expect(switch).to be_valid |
There was a problem hiding this comment.
For some reason calling .delete only fails when calling this method twice? In our request this method is called twice, resulting in this bug, to recreate it in this spec we have to call it twice...
njaeggi
commented
Dec 30, 2024
| @@ -40,7 +40,7 @@ def validate_roles | |||
| # But this method should not save the roles, so we must roll back after checking the validity. | |||
| Role.transaction(requires_new: true) do | |||
| roles_to_destroy, roles_to_update = roles.partition(&:marked_for_destruction?) | |||
| roles_to_destroy.each { |role| role.delete } | |||
| roles_to_destroy.each { |role| role.really_destroy! } | |||
There was a problem hiding this comment.
We should call the same as we would in our save method anyways, where we use really_destroy! for all roles marked for destruction...
This still won't destroy the role on validation, because of the transaction
njaeggi
force-pushed
the
bug/1357/switch-stammsektion-with-new-role
branch
from
715c29e to
f6020fc
Compare
…will be deleted anyways
njaeggi
force-pushed
the
bug/1357/switch-stammsektion-with-new-role
branch
from
f6020fc to
a22fd73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…will be deleted anyways