-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: LinkBlocks format is not supported in articles #371
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I'm facing an issue atm which has been taking up most of my time so far. I can't understand the way the renderer is structured/how it works as there seem to be svelte files and pug files with similar code as well as a
|
Split on few independent PRs/commits.
|
@markholdex @gregorymcmillan When you have a moment, please provide the article which contains a rich link element |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@surajsharma If you check their docs, you will they that they don't support browser usage, check my comment one more time |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@markholdex please where exactly is the issue occuring?.What component or page does the issue occur.What is the test article for |
@Isaacprogi this is not a bug to occur on a specific page or component. The Problem has the To solve the Problem, you must provide a solution that will make sure LinkBlocks are supported. |
Test article is for you to use locally to test if your implementation works or not. As the name suggest, it's for testing purposes. |
@markholdex please can i have a before and after image for the problem and where it should be applicable in the test article. Also I am trying to locate the components or page of the "test article" locally but cant seem to. Does it having a different configuration from the normal c route. The route is working but am trying to find component page |
Also where exactly is the link displayed as text here |
@Isaacprogi You have the local thread available in the description, check it. Note: Pay attention to the payload you get from API before it is rendered and you will get the point. |
@Isaacprogi please take a close look at the test article and at the component design in Figma. |
@markholdex Okay understood |
@georgeciubotaru not clear on this. Please can you point to |
@Isaacprogi please check the description of the Problem. You will find instructions to run local environment there. When you run locally pay attention to the Payload that needs to be parsed. |
Okay,clear |
@markholdex this is what i have so far |
@Isaacprogi Good progress so far. Don't forget to link your active Pull Request with this Issue as stated in our Principles document. Regarding the Title and description: They should be taken form the OG meta information of the link. |
Okay |
Figma component design
Figma article design
Solution
Whenever a link (not anchor) is encountered by the
renderer
parser component, it is parsed and should be displayed as a LinkBlock component inside the article body. Example article: https://holdex.io/c/learn/editorial-guidelines (notice in the beginning we have a link that's displayed as text). To view this article on your local machine, change the parameters following this comment instruction.Test article available on localhost
The text was updated successfully, but these errors were encountered: