Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: LinkBlocks format is not supported in articles #371

Open
markholdex opened this issue Jun 12, 2023 · 39 comments · May be fixed by #565
Open

Problem: LinkBlocks format is not supported in articles #371

markholdex opened this issue Jun 12, 2023 · 39 comments · May be fixed by #565
Labels
type: feat New feature or request

Comments

@markholdex
Copy link
Contributor

markholdex commented Jun 12, 2023

Figma component design

Figma article design

Solution

Whenever a link (not anchor) is encountered by the renderer parser component, it is parsed and should be displayed as a LinkBlock component inside the article body. Example article: https://holdex.io/c/learn/editorial-guidelines (notice in the beginning we have a link that's displayed as text). To view this article on your local machine, change the parameters following this comment instruction.

Test article available on localhost

@sipofnightshade

This comment was marked as outdated.

@zolotokrylin

This comment was marked as outdated.

@zolotokrylin zolotokrylin added the type: feat New feature or request label Jun 15, 2023
@sipofnightshade

This comment was marked as outdated.

@markholdex

This comment was marked as outdated.

@sipofnightshade
Copy link

I'm facing an issue atm which has been taking up most of my time so far. I can't understand the way the renderer is structured/how it works as there seem to be svelte files and pug files with similar code as well as a template.pug file which I'm also not certain what it's purpose is. I would like to know the following:

  • Where exactly I should import and render the richLink component?
  • Where can I find a post with rich links so I can test my component?

@zolotokrylin
Copy link
Member

Start here @gregorymcmillan

image

@zolotokrylin
Copy link
Member

Split on few independent PRs/commits.

  • start with pure UI (no networking and no controllers/parsers).

@zolotokrylin
Copy link
Member

@markholdex @gregorymcmillan When you have a moment, please provide the article which contains a rich link element

@holdex holdex deleted a comment from zolotokrylin Jun 16, 2023
@holdex holdex deleted a comment from zolotokrylin Jun 16, 2023
@holdex holdex deleted a comment from zolotokrylin Jun 16, 2023
@holdex holdex deleted a comment from markholdex Jun 20, 2023
@wryonik

This comment was marked as outdated.

@predrag-us

This comment was marked as outdated.

@predrag-us

This comment was marked as outdated.

@markholdex markholdex assigned surajsharma and unassigned wryonik Aug 21, 2023
@surajsharma surajsharma linked a pull request Aug 22, 2023 that will close this issue
@surajsharma

This comment was marked as outdated.

@predrag-us

This comment was marked as outdated.

@surajsharma

This comment was marked as outdated.

@surajsharma

This comment was marked as outdated.

@georgeciubotaru
Copy link
Contributor

@surajsharma If you check their docs, you will they that they don't support browser usage, check my comment one more time

@surajsharma

This comment was marked as outdated.

@georgeciubotaru

This comment was marked as outdated.

@markholdex markholdex changed the title Problem: links in article body are not displayed in rich format Problem: rich links format is not supported in articles Dec 21, 2023
@markholdex markholdex changed the title Problem: rich links format is not supported in articles Problem: LinkBlocks format is not supported in articles Dec 21, 2023
@markholdex markholdex moved this from 🏗 In progress to 🔖 Ready in Bounties 🥥🍫 Dec 21, 2023
@markholdex markholdex removed a link to a pull request Dec 29, 2023
@Isaacprogi
Copy link

Isaacprogi commented Dec 29, 2023

@markholdex please where exactly is the issue occuring?.What component or page does the issue occur.What is the test article for

@markholdex
Copy link
Contributor Author

@Isaacprogi this is not a bug to occur on a specific page or component. The Problem has the Enhancement label which means it's a new feature that requires development. The title denotes that this feature is not supported at all in any of our articles.

To solve the Problem, you must provide a solution that will make sure LinkBlocks are supported.

@markholdex
Copy link
Contributor Author

Test article is for you to use locally to test if your implementation works or not. As the name suggest, it's for testing purposes.

@Isaacprogi
Copy link

@markholdex please can i have a before and after image for the problem and where it should be applicable in the test article. Also I am trying to locate the components or page of the "test article" locally but cant seem to. Does it having a different configuration from the normal c route. The route is working but am trying to find component page

@Isaacprogi
Copy link

Also where exactly is the link displayed as text here
https://holdex.io/c/learn/editorial-guidelines

@georgeciubotaru
Copy link
Contributor

@Isaacprogi You have the local thread available in the description, check it.

Note: Pay attention to the payload you get from API before it is rendered and you will get the point.

@markholdex
Copy link
Contributor Author

@Isaacprogi please take a close look at the test article and at the component design in Figma.
Screenshot 2023-12-29 at 14 13 44

@Isaacprogi
Copy link

@markholdex Okay understood

@Isaacprogi
Copy link

Isaacprogi commented Dec 29, 2023

@Isaacprogi You have the local thread available in the description, check it.

Note: Pay attention to the payload you get from API before it is rendered and you will get the point.

@georgeciubotaru not clear on this. Please can you point to

@markholdex
Copy link
Contributor Author

@Isaacprogi You have the local thread available in the description, check it.
Note: Pay attention to the payload you get from API before it is rendered and you will get the point.

@georgeciubotaru not clear on this. Please can you point to

@Isaacprogi please check the description of the Problem. You will find instructions to run local environment there.

When you run locally pay attention to the Payload that needs to be parsed.

@Isaacprogi
Copy link

Isaacprogi commented Dec 29, 2023

@Isaacprogi You have the local thread available in the description, check it.
Note: Pay attention to the payload you get from API before it is rendered and you will get the point.

@georgeciubotaru not clear on this. Please can you point to

@Isaacprogi please check the description of the Problem. You will find instructions to run local environment there.

When you run locally pay attention to the Payload that needs to be parsed.

Okay,clear

@Isaacprogi
Copy link

@markholdex this is what i have so far
linkfix
What should replace the title and description of the links

@markholdex
Copy link
Contributor Author

@markholdex this is what i have so far linkfix What should replace the title and description of the links

@Isaacprogi Good progress so far. Don't forget to link your active Pull Request with this Issue as stated in our Principles document.

Regarding the Title and description: They should be taken form the OG meta information of the link.

@Isaacprogi
Copy link

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feat New feature or request
Projects
Status: 🔖 Ready
Development

Successfully merging a pull request may close this issue.

8 participants