Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using total trace duration as a sample weight source #1164

Open
n-oden opened this issue May 22, 2024 · 1 comment
Open

Allow using total trace duration as a sample weight source #1164

n-oden opened this issue May 22, 2024 · 1 comment
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: enhancement New feature or request

Comments

@n-oden
Copy link

n-oden commented May 22, 2024

Is your feature request related to a problem? Please describe.

Given a sampling strategy such as "sample 100% of 5xx errors but sample successful/2xx traces at 1/10", I probably am more interested in examples of the latter that took >60s than <10ms, but there is currently no way to express that in any of refinery's samplers.

Describe the solution you'd like

I would like to be able to use total trace duration in sampling rules. :)

Additional context

Discussion on honeycomb slack: https://honeycombpollinators.slack.com/archives/C01BZ3J7RMJ/p1716390012880539

@n-oden n-oden added the type: enhancement New feature or request label May 22, 2024
@MikeGoldsmith MikeGoldsmith added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label May 23, 2024
@MikeGoldsmith
Copy link
Contributor

Hi @n-oden - sorry for the slow reply.

This is an interesting feature request. We'll discuss internally and add to our backlog for consideration. We're unsure when development might happen.

If you want to work on it and a proposal and/or a PR, we'd happy to review and provide feedback.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: oncall Flagged for awareness from Honeycomb Telemetry Oncall type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants