Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement properties.timeout for account().tokens.add(properties) #18

Closed
gr2m opened this issue Oct 18, 2016 · 8 comments · Fixed by #43
Closed

implement properties.timeout for account().tokens.add(properties) #18

gr2m opened this issue Oct 18, 2016 · 8 comments · Fixed by #43
Assignees

Comments

@gr2m
Copy link
Member

gr2m commented Oct 18, 2016

properties.timeout is optional and defaults to 7200 (2h in seconds).

If token is expired, then sessions.add({token: 'expiredtoken123'}) should reject with 404 token expired

@Taekyoon
Copy link
Contributor

Can I do this issue?!

@gr2m
Copy link
Member Author

gr2m commented Nov 10, 2016

maybe finish #17 first :) but sure, all yours, let me know if you need any help

@Taekyoon
Copy link
Contributor

@gr2m I'll assign this issue to @vkai. And I'll work together with him. Is it fine?

@gr2m
Copy link
Member Author

gr2m commented Nov 17, 2016

sure thing 👍

@gr2m
Copy link
Member Author

gr2m commented Nov 17, 2016

I’ve invited you both to Hoodie’s contributors team. You can accept it at https://github.com/hoodiehq

@Taekyoon
Copy link
Contributor

Taekyoon commented Nov 18, 2016

@gr2m @vkai Hey Greg, we just added some code to figure out this issue on Wednesday, but we didn't make test code. The reason is we have no idea where we should put code in the project. Where do we put the test code in this proejct?

p.s) In issue #17 I already added tokens-test.js to test validating token.type.

@gr2m
Copy link
Member Author

gr2m commented Nov 20, 2016

I’ve merged #36 now, you can add tests for this to tokens-test.js, too

@Taekyoon
Copy link
Contributor

@gr2m Thanks Greg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants