Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few questions about the Cloudflare integration #1220

Closed
kodster28 opened this issue May 29, 2024 · 3 comments
Closed

A few questions about the Cloudflare integration #1220

kodster28 opened this issue May 29, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@kodster28
Copy link
Contributor

kodster28 commented May 29, 2024

Howdy 👋 ,

Working on a corresponding page for this in the Cloudflare docs and had a few questions that I need answered in this PR.

Questions

  1. If I'm reading this line correctly, it sounds like their example is actually incorrect and might need to be updated?
  2. If ^^^ is correct, does that mean that we should also be specifying the model parameter w/in the endpoint configuration?
  3. Correct assumption that this only works with models prefixed with @hf, think so based on their code.

Mind helping me out so I can get this live in our docs?

@nsarrazin nsarrazin added the documentation Improvements or additions to documentation label May 30, 2024
@nsarrazin nsarrazin self-assigned this May 30, 2024
@nsarrazin
Copy link
Collaborator

Hey! Thanks for taking a look at this.

  1. Yes our example is incorrect, will update the docs to fix it
  2. No need, model is passed from inside chat-ui so it's all good.
  3. Yes I think so for now, though it could be made configurable if we want! (and if the APIs are compatible, not sure how it works cloudflare side)

@kodster28
Copy link
Contributor Author

Hey! Thanks for taking a look at this.

  1. Yes our example is incorrect, will update the docs to fix it
  2. No need, model is passed from inside chat-ui so it's all good.
  3. Yes I think so for now, though it could be made configurable if we want! (and if the APIs are compatible, not sure how it works cloudflare side)

Thanks @nsarrazin, happy to close out this issue or let you do it as this has answered my questions. I'll bring up 3 with the PM.

@kodster28
Copy link
Contributor Author

Related #1226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants