Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-generation-inference docker builds are not reproducible due to missing Cargo.lock causing builds to fail on previous versions #677

Closed
1 of 4 tasks
charlesmelby opened this issue Aug 8, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@charlesmelby
Copy link

charlesmelby commented Aug 8, 2024

System Info

system: inf2.48xlarge instance
OS: Amazon Linux 2023

build was done with v0.0.23 but mainline has same issue

Who can help?

@dacorvo

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction (minimal, reproducible, runnable)

To reproduce:

git clone https://github.com/huggingface/optimum-neuron --branch=v0.0.23
cd optimum-neuron
make neuronx-tgi

Error message:

error: package `bitstream-io v2.5.0` cannot be built because it requires rustc 1.79 or newer, while the currently active rustc version is 1.75.0
Either upgrade to rustc 1.79 or newer, or use
cargo update [email protected] --precise ver
where `ver` is the latest version of `bitstream-io` supporting rustc 1.75.0
thread 'main' panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-chef-0.1.62/src/recipe.rs:204:27:
Exited with status code: 101
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior

I expect the build to succeed.
Cargo.lock has bitstream-io v2.2.0 but it's not being used so invalid dependencies are being collected.

Build goes through when Cargo.lock is added as in TGI repo
https://github.com/huggingface/text-generation-inference/blob/8094ecfc9ef22c838fa7d49db4af8301539619e3/Dockerfile#L8

@charlesmelby charlesmelby added the bug Something isn't working label Aug 8, 2024
@charlesmelby
Copy link
Author

@dacorvo
Sorry didn't tag you properly before.

@dacorvo dacorvo self-assigned this Aug 26, 2024
@schauaib
Copy link

Heelo,
Any update about this ?

@dacorvo
Copy link
Collaborator

dacorvo commented Sep 30, 2024

This was fixed as part of #696

@dacorvo dacorvo closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants