Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create-react-wp-plugin and create-react-wp-theme packages #24

Open
rmccue opened this issue Mar 7, 2018 · 1 comment
Open

Add create-react-wp-plugin and create-react-wp-theme packages #24

rmccue opened this issue Mar 7, 2018 · 1 comment

Comments

@rmccue
Copy link
Member

rmccue commented Mar 7, 2018

We should make running this as easy as CRA itself. I want to be able to run:

npx create-react-wp-theme your-directory/
npx create-react-wp-plugin your-directory/
@rmccue rmccue mentioned this issue Mar 9, 2018
3 tasks
@roborourke
Copy link
Contributor

roborourke commented May 25, 2018

So something I ran into is that the default webpack config in CRA uses the standard jsonpFunction name. I'm not sure it'd come up if not using code splitting but if someone is planning to use CRA for a plugin or theme things can break if config.output.jsonpFunction isn't namespaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants