Skip to content
This repository has been archived by the owner on Oct 22, 2020. It is now read-only.

Refactor helpers code and test into smaller and self-contained files #31

Open
nicolapaoli opened this issue Mar 22, 2019 · 3 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nicolapaoli
Copy link
Contributor

No description provided.

@nicolapaoli nicolapaoli added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 22, 2019
@nicolapaoli nicolapaoli added this to the Performance Enhancement milestone Mar 22, 2019
@alexvicegrab
Copy link
Contributor

alexvicegrab commented Jun 13, 2019

This pertains to the helpers/misc.py and helpers/k8s.py files.

The first could separate the code for execution of commands (especially if we eventually move the Helm functionality to use an outside library as discussed in #44 or another alternative)

The second is 300 lines long and could be broken down into things that manage K8S secrets and configuration vs. the rest, for example. Similarly, the Executer might be moved into a separate file as well.

@0xamogh
Copy link
Contributor

0xamogh commented Aug 30, 2019

Hi, can I take this up?

@0xamogh
Copy link
Contributor

0xamogh commented Sep 15, 2019

This pertains to the helpers/misc.py and helpers/k8s.py files.

The first could separate the code for execution of commands (especially if we eventually move the Helm functionality to use an outside library as discussed in #44 or another alternative)

The second is 300 lines long and could be broken down into things that manage K8S secrets and configuration vs. the rest, for example. Similarly, the Executer might be moved into a separate file as well.

Hey, wanted to clarify a few things.
Do you want to seperate all the functions from the misc.py file?
Also I'm unable to find documentation for a few comments in k8s.py eg. Ingress on line #124

0xamogh added a commit to 0xamogh/nephos that referenced this issue Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants